Comments on the same line as variable declarations for make #18291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating building julia with threading disabled and discovered changing the value in
Make.incdid not seem to be doing anything. After some investigation, I found out that the comment on the same line in the variable declaration was causing the variable value to have trailing whitespace characters, and so theifneq ($(JULIA_THREADS), 0)just always returned true. This behavior is noted in the GNU make manual.I saw there were a couple other places where the same thing happened so I changed those and added a warning up top. Let me know if that's just adding noise and I can remove the warning.