Add a more efficient implementation of in(::CartesianIndex, ::CartesianRange) #18277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The windows failures seem spurious, so this seems OK. I'll leave it open a bit longer, unless @tkelman wants to backport it ASAP. (I don't think that's necessary, though.) |
|
worth restarting appveyor since we're not super busy right now - the 64 bit failure was #16555, 32 bit was a freeze but not sure where |
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this fell back to the generic implementation, requiring iteration over every element in the CartesianRange.