Revert #182599 "add faster done for strings" #18275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 30ee10b.
tkelman
added
domain:unicode
|
probably shouldn't have squashed this, worth backporting the added test |
TotalVerb
added a commit
to TotalVerb/julia
that referenced
this pull request
Aug 29, 2016
This reverts commit 6d179b3.
|
As @TotalVerb pointed out, this test might not be good because it is creating an invalid UTF8 String. Perhaps the original fix is correct for all valid strings. But someone more knowledgeable than about UTF should probably comment. |
|
okay, but while "what to do with invalid unicode" is still being worked out, I'm not going to backport any behavior changes right now |
|
Yes, I just meant not backport the test. |
|
See #18280. |
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
* Revert "add faster done for strings (JuliaLang#18259)" This reverts commit 30ee10b. * add test that failed with JuliaLang#18259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad for merging without getting a proper review.
cc @tkelman