-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set LIB_INSTALL_DIR for cmake-based projects #18047
Conversation
This fixes `MULTIARCH_INSTALL=1` installations that place libraries not into `<prefix>/lib` but into `<prefix>/lib/<host-triplet>`, like Debian and Ubuntu. Without this change, `libgit2`, `libssh2` and `mbedtls` would place libraries into `<prefix>/lib`, silently failing until the Julia bootstrap process attempted to dlopen one of them.
Confirmed that this has allowed a For reference, the
|
We aren't building LLVM with cmake by default yet, but would this be needed there if we did? |
Almost certainly. |
Why not put this in |
One thing to think about before I do that; on Windows we set |
I don't think we want the static libraries at all for any of the libraries that we build using cmake. |
Done and done, let's see if this works, I'll test it with |
Same result with this change, so I think it's good to go. |
* Set LIB_INSTALL_DIR for cmake-based projects This fixes `MULTIARCH_INSTALL=1` installations that place libraries not into `<prefix>/lib` but into `<prefix>/lib/<host-triplet>`, like Debian and Ubuntu. Without this change, `libgit2`, `libssh2` and `mbedtls` would place libraries into `<prefix>/lib`, silently failing until the Julia bootstrap process attempted to dlopen one of them. * Apply `LIB_INSTALL_DIR` to `CMAKE_COMMON` (cherry picked from commit 1af5356)
* Set LIB_INSTALL_DIR for cmake-based projects This fixes `MULTIARCH_INSTALL=1` installations that place libraries not into `<prefix>/lib` but into `<prefix>/lib/<host-triplet>`, like Debian and Ubuntu. Without this change, `libgit2`, `libssh2` and `mbedtls` would place libraries into `<prefix>/lib`, silently failing until the Julia bootstrap process attempted to dlopen one of them. * Apply `LIB_INSTALL_DIR` to `CMAKE_COMMON`
This fixes
MULTIARCH_INSTALL=1
installations that place libraries notinto
<prefix>/lib
but into<prefix>/lib/<host-triplet>
, like Debianand Ubuntu. Without this change,
libgit2
,libssh2
andmbedtls
would place libraries into
<prefix>/lib
, silently failing until theJulia bootstrap process attempted to dlopen one of them.
This is at least one problem that has held up the Ubuntu nightlies.