Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indices-aware find and fixes for logical indexing #18040

Merged
merged 2 commits into from
Aug 16, 2016
Merged

Conversation

timholy
Copy link
Sponsor Member

@timholy timholy commented Aug 15, 2016

Stuff I should have gotten right a long time ago 😦

@timholy timholy added backport pending 0.5 kind:bugfix This change fixes an existing bug labels Aug 15, 2016
@tkelman
Copy link
Contributor

tkelman commented Aug 16, 2016

@nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@timholy
Copy link
Sponsor Member Author

timholy commented Aug 16, 2016

I was unable to replicate any of these differences (neither improvements nor regressions)---the two seem indistinguishable on every one of those tests that I checked (~40% of them).

@timholy timholy merged commit c270a23 into master Aug 16, 2016
@timholy timholy deleted the teh/find_indices branch August 16, 2016 12:43
tkelman pushed a commit that referenced this pull request Aug 20, 2016
(cherry picked from commit 6f1ad9c)
ref #18040
tkelman pushed a commit that referenced this pull request Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants