Fix missing type parameter in _array_for #18009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a performance regression in the lucompletepiv benchmark triggered by generalizing _array_for to work with indices. This call, first introduced in b363cc7, likely always triggered dynamic method dispatch. The generalization to indices seemed to make that worse.
|
Worth checking with @JeffBezanson on whether the original design was part of a strategy to reduce specializations (for compiler performance). |
|
yay. let's verify @nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
None of the apparent regressions are reproducible for me, but the performance improvements on |
tkelman
pushed a commit
that referenced
this pull request
Aug 20, 2016
This fixes a performance regression in the lucompletepiv benchmark triggered by generalizing _array_for to work with indices. This call, first introduced in b363cc7, likely always triggered dynamic method dispatch. The generalization to indices seemed to make that worse. (cherry picked from commit cb623f8) ref #18009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance regression in the lucompletepiv benchmark triggered by generalizing
_array_forto work with indices. Ref #17960 (comment).This call, first introduced in b363cc7, likely always triggered dynamic method dispatch. Unfortunately, the generalization to indices seemed to make that worse. This new version should be type stable and improves the performance of that benchmark by almost exactly twofold.