Fix atahn to atanh #17977
Merged
Fix atahn to atanh #17977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but a @kshyatt PR that doesn't have tests? My world is shaken. |
|
My doc prs don't have tests... I'll see if I can trigger the bug on master. We do have tests for |
|
Judging by the packages that failed, it's probably triggered by defining a custom AbstractArray type that goes to the fallback - the existing tests for atanh are probably hitting more specialized methods? |
tkelman
pushed a commit
that referenced
this pull request
Aug 12, 2016
* Fix atahn to atanh * More tests (cherry picked from commit 5838a12)
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
* Fix atahn to atanh * More tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.