Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Integer-typed empty arrays #17891

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Add test for Integer-typed empty arrays #17891

merged 1 commit into from
Aug 9, 2016

Conversation

ranjanan
Copy link
Contributor

@ranjanan ranjanan commented Aug 8, 2016 •
edited
Loading

cc: @JeffBezanson

This is a test for PR #17847

@ranjanan ranjanan mentioned this pull request Aug 8, 2016
Closed
@ranjanan ranjanan changed the title Add test Add test for Integer-typed empty arrays Aug 8, 2016
@ranjanan
Copy link
Contributor Author

ranjanan commented Aug 8, 2016

I put this test in inference.jl, but that's probably the wrong place. I could move it if you let me know.

@tkelman
Copy link
Contributor

tkelman commented Aug 8, 2016

please be more descriptive with your commit messages

@kshyatt kshyatt added test This change adds or pertains to unit tests types and dispatch Types, subtyping and method dispatch labels Aug 8, 2016
@JeffBezanson JeffBezanson merged commit ea939f6 into JuliaLang:jb/empty_comprehensions_take_2 Aug 9, 2016
@ranjanan ranjanan deleted the jb/empty_comprehensions_take_2 branch August 9, 2016 15:12
@ranjanan ranjanan restored the jb/empty_comprehensions_take_2 branch August 9, 2016 15:13
JeffBezanson pushed a commit that referenced this pull request Aug 9, 2016
@ranjanan @JeffBezanson
test for #17811, type of e.g. abs(Integer[]) (#17891)
93c6061 
This tests that the result type of an empty comprehension is big enough to hold the possible results.
tkelman pushed a commit that referenced this pull request Aug 11, 2016
@ranjanan @tkelman
test for #17811, type of e.g. abs(Integer[]) (#17891)
916d894 
This tests that the result type of an empty comprehension is big enough to hold the possible results.
(cherry picked from commit 93c6061)
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
@ranjanan @mfasi
test for JuliaLang#17811, type of e.g. abs(Integer[]) (JuliaLang#17891
451a173 
)

This tests that the result type of an empty comprehension is big enough to hold the possible results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranjanan @tkelman @JeffBezanson @kshyatt