Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for function name being assigned in function #17835

Merged
merged 4 commits into from
Aug 9, 2016

Conversation

ranjanan
Copy link
Contributor

@ranjanan ranjanan commented Aug 5, 2016

This adds a test for #4914.

@@ -513,3 +513,11 @@ let s = "Monkey 🙈🙊🙊"
@test tf(2) == "Mo|nk|ey| 🙈|🙊🙊"
@test tf(1) == "M|o|n|k|e|y| |🙈|🙊|🙊"
end

# Issue 4914
let
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core is probably better for this. functional is for higher order functional programming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'll shift.

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Aug 5, 2016
@ranjanan
Copy link
Contributor Author

ranjanan commented Aug 8, 2016

@tkelman is there anything I need to add to this PR?

@ranjanan
Copy link
Contributor Author

ranjanan commented Aug 8, 2016

@vtjnash Could you please help review this code and let me know if I should change anything?

let
j(j) = j
@test j(1) == 1
k(x) = (k = x; x)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example in the issue is (k = x; k).

@ranjanan
Copy link
Contributor Author

ranjanan commented Aug 9, 2016

Looks like a LibGit2 error on Appveyor and a Travis timeout

@JeffBezanson JeffBezanson merged commit 932ce0c into JuliaLang:master Aug 9, 2016
@ranjanan ranjanan deleted the RA/testadd branch August 9, 2016 15:32
tkelman pushed a commit that referenced this pull request Aug 11, 2016
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants