Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard nomenclature for UNIX domain sockets #17601

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

sorear
Copy link
Contributor

@sorear sorear commented Jul 25, 2016

UNIX modifies "domain", not "domain socket"; "UNIX domain" modifies "socket", and "domain socket" by itself is meaningless.

This matches the phrasing and capitalization from POSIX.1:

http:https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_10_17


I looked at some other recently submitted PRs, and this comment suggested running "make docs" after a doc change, but when I did that it resulted in some extraneous whitespace changes in doc/stdlib/parallel.rst.

UNIX modifies "domain", not "domain socket"; "UNIX domain" modifies
"socket", and "domain socket" by itself is meaningless.

This matches the phrasing and capitalization from POSIX.1:

http:https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_10_17
PipeServer(active)

Note that the return type of the last invocation is different. This is because
this server does not listen on TCP, but rather on a named pipe (Windows)
or domain socket (UNIX). The difference
or UNIX domain socket (UNIX). The difference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit redundant to say it twice?

@StefanKarpinski
Copy link
Sponsor Member

Do we support similar functionality on non-POSIX systems like Windows? If so, we should use more generic terminology and give UNIX domain sockets as an example system-level implementation somewhere. cc @vtjnash, @Keno

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 25, 2016

The Windows name is Named Pipe, as given here

@sorear
Copy link
Contributor Author

sorear commented Jul 25, 2016

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365590(v=vs.85).aspx

A named pipe is a named, one-way or duplex pipe for communication between the pipe server and one or more pipe clients. All instances of a named pipe share the same pipe name, but each instance has its own buffers and handles, and provides a separate conduit for client/server communication. The use of instances enables multiple pipe clients to use the same named pipe simultaneously.

AFAICT it's "named pipe", not "Named Pipe".

@vtjnash vtjnash merged commit 6f4cc70 into JuliaLang:master Jul 25, 2016
@sorear sorear deleted the topic/unix-domain-nomenclature branch July 25, 2016 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants