Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more docs to repl completion. #17580

Merged
merged 2 commits into from
Jul 24, 2016
Merged

Conversation

dhoegh
Copy link
Contributor

@dhoegh dhoegh commented Jul 23, 2016

No description provided.

@tkelman tkelman added domain:docs This change adds or pertains to documentation stdlib:REPL Julia's REPL (Read Eval Print Loop) labels Jul 23, 2016
@@ -228,11 +228,56 @@ and get a list of LaTeX matches as well::
\hat \heartsuit \hksearow \hookleftarrow \hslash
\hbar \hermitconjmatrix \hkswarow \hookrightarrow \hspace

julia> α="\alpha[TAB]" # LaTeX complation do also work in strings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completion also works in strings

@dhoegh dhoegh force-pushed the repl_comp_doc branch 2 times, most recently from 4430cab to b1283de Compare July 23, 2016 13:36

julia> max([TAB] # Methods are displayed, not shown here ...

julia> max([1,2],[TAB] # All methods where array match as first argument
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where array matches as

@dhoegh
Copy link
Contributor Author

dhoegh commented Jul 23, 2016

Thank you Tony for the review. I have addressed your comments.

@tkelman
Copy link
Contributor

tkelman commented Jul 23, 2016

julia> max([TAB] # All methods is displayed, not display here due to size of the list should have been left mostly intact, just as
julia> max([TAB] # All methods are displayed, not shown here due to size of the list, I didn't mean the "..." literally

@dhoegh
Copy link
Contributor Author

dhoegh commented Jul 23, 2016

I see. I have fixed it.

@ViralBShah
Copy link
Member

@tkelman Merge?

@tkelman
Copy link
Contributor

tkelman commented Jul 23, 2016

Usually would rather leave things open for review longer than 5 hours.


julia> max([TAB] # All methods are displayed, not shown here due to size of the list

julia> max([1,2],[TAB] # All methods where array matches as first argument
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe be more specific and say "...where Vector{Int} matches..."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it to Vector{Int}.

@tkelman tkelman merged commit aa2e898 into JuliaLang:master Jul 24, 2016
@dhoegh dhoegh deleted the repl_comp_doc branch July 24, 2016 09:10
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
* Add more doc to repl completion.

* Fix comments [ci skip].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants