Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17553 #17566

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Fix #17553 #17566

merged 1 commit into from
Jul 22, 2016

Conversation

Keno
Copy link
Member

@Keno Keno commented Jul 22, 2016 •
edited
Loading

Fixes #17553

@Keno Keno changed the title Fix 17553 Fix #17553 Jul 22, 2016
@tkelman
Copy link
Contributor

tkelman commented Jul 22, 2016

please make your commit message more descriptive

@Keno Keno merged commit 3503a59 into master Jul 22, 2016
@yuyichao yuyichao deleted the kf/17553 branch July 22, 2016 20:47
@Keno
Copy link
Member Author

Keno commented Jul 22, 2016

To elaborate, I didn't want to update the commit message on this branch, because that would have interrupted CI, requiring us to wait longer to merge this (and since this breaks Pkg.update I wanted to get this done quickly). I've updated the commit message as part of the merge. I also realize that my earlier comment was more brash than funny, so I've removed it. My apologies.

mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
@Keno @mfasi
Reverse order of keydefpath checks (JuliaLang#17566)
8f03766 
If keydefpath is nothing, we can't call `isempty` on it, so we should check for that first.

Fixes JuliaLang#17553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Keno @tkelman