some doc and deprecation fixes #17565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- minor fixes to DocCheck.jl, but it needs much more work - add docs for isimag, clamp!, and isassigned - fix deprecation for pmap keyword arguments
|
|
||
| pmap(p, f, c...; kwargs...) | ||
| end | ||
| # deprecation warnings are in pmap.jl |
There was a problem hiding this comment.
this is going to be really easy to overlook
There was a problem hiding this comment.
Well, I tried. Unfortunately we simply don't have a way to deprecate a subset of keyword arguments using a separate definition.
There was a problem hiding this comment.
so has the deprecation been broken in its current form?
There was a problem hiding this comment.
Yes, the deprecation did not work.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stuff I came across when looking for undocumented stuff.
@stevengj I believe
besselhxis also undocumented.