Fix #17105, @ inferred with kwargs #17346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. Can someone with kwarg dispatch expertise take a look at this? |
Also fixes #9818 (incorrect @ code_typed with kwargs) since otherwise @ inferred with kwargs would sometimes be wrong.
[ci skip]
|
This seemed to make the numbers test dramatically slower on 32 bit Linux ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #9818 (incorrect
@code_typedwith kwargs) since otherwise@inferredwith kwargs would sometimes be wrong. This does not fix #17127, so@code_typedoutput is still not necessarily useful.Someone who knows how keyword argument dispatch works should check that I'm doing this right.