Fix #16326: use typesof in code_* for all :call expressions #17096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 This is much needed. I wonder what's causing the failure? |
Update docs/utils.jl to pass test (h/t MichaelHatherly).
|
test? |
| @@ -278,7 +278,8 @@ typesof(args...) = Tuple{map(a->(isa(a,Type) ? Type{a} : typeof(a)), args)...} | |||
| gen_call_with_extracted_types(fcn, ex0::Symbol) = Expr(:call, fcn, Meta.quot(ex0)) | |||
| function gen_call_with_extracted_types(fcn, ex0) | |||
| if isa(ex0, Expr) && | |||
| any(a->(Meta.isexpr(a, :kw) || Meta.isexpr(a, :parameters)), ex0.args) | |||
| (any(a->(Meta.isexpr(a, :kw) || Meta.isexpr(a, :parameters)), ex0.args) || | |||
| ex0.head == :call) | |||
There was a problem hiding this comment.
I think this kills the branch in 296 completely. The main requirement for fixing #17469 is that the expression goes through the expand step in line 290. However, it's hard to predict the consequences of changes to this function.
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about
The tricky cases [...] like ref for getindex, vcat, etc., but this fixes #16326 and #16487.