Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base.transcode to replace utf8to16 and utf16to8 #16974

Merged
merged 1 commit into from
Jun 16, 2016

Conversation

StefanKarpinski
Copy link
Sponsor Member

No description provided.

@nalimilan
Copy link
Member

nalimilan commented Jun 16, 2016

Why not, but it doesn't sound like a very general definition either: is it supposed to support only conversions between Unicode encodings? A really general method would also need to take information about source and destination encodings instead of inferring it from the input integer size.

@StefanKarpinski
Copy link
Sponsor Member Author

It's not meant to be general or even used outside of simple calls to C APIs. Having this be generic instead of having the type implicit as part of the name is helpful when implementing conversion to and from Cwstring without the WString type, which I'm working on removing (deprecating).

@StefanKarpinski StefanKarpinski merged commit 00ba80d into JuliaLang:master Jun 16, 2016
@StefanKarpinski StefanKarpinski mentioned this pull request Jul 5, 2016
32 tasks
@tkelman tkelman added the needs docs Documentation for this change is required label Jul 7, 2016
stevengj added a commit to stevengj/julia that referenced this pull request Jul 7, 2016
…ing, x) and transcode(T, ::String) convenience methods
@tkelman tkelman removed the needs docs Documentation for this change is required label Jul 7, 2016
stevengj added a commit to stevengj/julia that referenced this pull request Jul 9, 2016
…ing, x) and transcode(T, ::String) convenience methods
stevengj added a commit to stevengj/julia that referenced this pull request Jul 11, 2016
…ing, x) and transcode(T, ::String) convenience methods
stevengj added a commit to stevengj/julia that referenced this pull request Jul 12, 2016
…ing, x) and transcode(T, ::String) convenience methods
stevengj added a commit to stevengj/julia that referenced this pull request Jul 12, 2016
…ing, x) and transcode(T, ::String) convenience methods
stevengj added a commit that referenced this pull request Jul 12, 2016
* export and document transcode from #16974, add transcode(String, x) and transcode(T, ::String) convenience methods

* docs

* support UTF-32 in transcode

* don't use splatting for UTF-32 to String conversion

* typo

* eliminate method ambiguities

* re-run genstdlib

* doc clarification

* typo
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
* export and document transcode from JuliaLang#16974, add transcode(String, x) and transcode(T, ::String) convenience methods

* docs

* support UTF-32 in transcode

* don't use splatting for UTF-32 to String conversion

* typo

* eliminate method ambiguities

* re-run genstdlib

* doc clarification

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants