Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename sub/slice -> view #16972

Merged
merged 2 commits into from
Jun 18, 2016
Merged

rename sub/slice -> view #16972

merged 2 commits into from
Jun 18, 2016

Conversation

simonbyrne
Copy link
Contributor

fixes #16846

tkelman
tkelman reviewed Jun 17, 2016
View reviewed changes
base/docs/helpdb/Base.jl
@@ -5402,14 +5402,14 @@ is raised as an exception in the woken tasks.
notify

"""
sub(A, inds...)
view(A, inds...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rst docs too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@simonbyrne simonbyrne changed the title WIP: rename sub/slice -> view rename sub/slice -> view Jun 17, 2016
@simonbyrne
Copy link
Contributor Author

Okay, looks like this is now working.

@timholy
Copy link
Sponsor Member

timholy commented Jun 17, 2016

👍 Of course, note that we have multiple view types now: ReshapedArray and the unexported PermutedDimsArray being two new ones for julia-0.5. Still, I think SubArray is the canonical view, so this is fine.

@StefanKarpinski
Copy link
Sponsor Member

Should SubArray be renamed to ArrayView while we're at it or would that be too disruptive?

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 18, 2016

Stefan, I think we should worry about that in v0.6 as we do a more bottom-up refactoring.

@StefanKarpinski
Copy link
Sponsor Member

Sounds good to me.

@simonbyrne
Copy link
Contributor Author

Any idea why appveyor is failing?

@JeffBezanson JeffBezanson merged commit 9d2a40b into master Jun 18, 2016
@tkelman tkelman deleted the sb/sub2view branch June 18, 2016 21:11
@tkelman
Copy link
Contributor

tkelman commented Jun 18, 2016

#16556

@simonbyrne simonbyrne mentioned this pull request Jun 19, 2016
Merged
simonbyrne added a commit that referenced this pull request Jun 19, 2016
@simonbyrne
add #16972 to NEWS.md
ea3b373
vtjnash added a commit that referenced this pull request Jun 23, 2016
@vtjnash
Merge pull request #17021 from JuliaLang/sb/sub2view-changes
1f74697 
add #16972 to NEWS.md
@ranjanan ranjanan mentioned this pull request Jun 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change sub behaviour to match getindex, possibly rename.
6 participants
@simonbyrne @timholy @StefanKarpinski @vtjnash @tkelman @JeffBezanson