Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up size on Arrays #16553

Merged
merged 1 commit into from
May 24, 2016
Merged

Speed up size on Arrays #16553

merged 1 commit into from
May 24, 2016

Conversation

timholy
Copy link
Sponsor Member

@timholy timholy commented May 24, 2016

According to BenchmarkTools, this is 70x faster on a 7-dimensional array.

Ref #16541.

According to BenchmarkTools, this is 70x faster on a 7-dimensional array
@timholy timholy mentioned this pull request May 24, 2016
@tkelman tkelman added the performance Must go faster label May 24, 2016
@andreasnoack
Copy link
Member

Just curious. Do you actually use 7-dimensional arrays?

@timholy
Copy link
Sponsor Member Author

timholy commented May 24, 2016

No, but occasionally I use 8-dimensional arrays 😄. They're useful in creating a tiled representation of a 4-dimensional array (A[innerdims..., outerdims...]), and tiling can improve the cache-efficiency of some algorithms.

@pkofod
Copy link
Contributor

pkofod commented May 24, 2016

Well, then what it is gain on an 8-dimensional array? :)

@JeffBezanson JeffBezanson merged commit c02f125 into master May 24, 2016
@tkelman tkelman deleted the teh/faster_size branch May 24, 2016 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants