Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up temporary files from tests #16551

Merged
merged 2 commits into from
May 24, 2016
Merged

Clean up temporary files from tests #16551

merged 2 commits into from
May 24, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented May 24, 2016

and make replcompletions test more robust to only finding a single completion

In combination with other tests setting random seeds, I actually fairly often see collisions in my /tmp folder of directories that haven't been deleted from past test runs. Some of those are from tests that fail and it's a little harder to keep track of those, but at least these I found as being created even when tests succeed, then not being cleaned up.

There are still 3 left in the parallel test here

julia/test/parallel_exec.jl

Lines 360 to 362 in fe23b88

if !is_windows()
# these give unlink: operation not permitted (EPERM) on Windows
rm(fn); rm(fn2); rm(fn3)
that I'm not quite sure what to do about, I've tried forcing finalization of the SharedArrays there but so far haven't gotten anything to work. fixed, yay

@tkelman tkelman added the test This change adds or pertains to unit tests label May 24, 2016
@JeffBezanson JeffBezanson merged commit b00fcb0 into master May 24, 2016
@tkelman tkelman deleted the tk/tempfiles branch May 24, 2016 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants