ensure macro expansion uses the right module #16533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passed, except for a networking failure in the pkg test. Is this testing something unreliable? From worker 3: * pkg Exception running test pkg :
On worker 3:
LoadError: GitError(Code:ERROR, Class:OS, Failed to receive response: The server returned an invalid or unrecognized response
)
in macro expansion at .\libgit2\error.jl:98 [inlined]
in #fetch#46 at .\libgit2\remote.jl:70
in #fetch at .\null:0
in #fetch#87 at .\libgit2.jl:159
in #18 at .\pkg\entry.jl:234
in transact at .\libgit2.jl:499
in with at .\libgit2\types.jl:660
in checkout at .\pkg\entry.jl:227
in #2 at .\pkg\dir.jl:31
in cd at .\file.jl:48
in #cd#1 at .\pkg\dir.jl:31
in #checkout#1 at .\pkg.jl:164
in #3 at C:\projects\julia\test\pkg.jl:74
in temp_pkg_dir at C:\projects\julia\test\pkg.jl:13
in temp_pkg_dir at C:\projects\julia\test\pkg.jl:7
in include_string at .\loading.jl:380
in include_from_node1 at .\loading.jl:429
in macro expansion at .\util.jl:179 [inlined]
in runtests at C:\projects\julia\test\testdefs.jl:7
in #16 at C:\projects\julia\test\runtests.jl:36
in #302 at .\multi.jl:1026
in run_work_thunk at .\multi.jl:750
in macro expansion at .\multi.jl:1026 [inlined]
in #301 at .\event.jl:46
while loading C:\projects\julia\test\pkg.jl, in expression starting on line 22
ERROR: LoadError: Some tests exited with errors.
in (::##11#19)() at C:\projects\julia\test\runtests.jl:64
in cd(::##11#19, ::String) at .\file.jl:48
in include_from_node1(::String) at .\loading.jl:426
in process_options(::Base.JLOptions) at .\client.jl:266
in _start() at .\client.jl:322
while loading C:\projects\julia\test\runtests.jl, in expression starting on line 13
Command exited with code 1 |
|
That error is happening often. Not sure if it's a new test or hitting recently refactored code paths. cc @wildart any ideas? |
| @@ -1702,7 +1702,7 @@ static jl_cgval_t emit_new_struct(jl_value_t *ty, size_t nargs, jl_value_t **arg | |||
| if (!init_as_value) { | |||
| // avoid unboxing the argument explicitely | |||
| // and use memcpy instead | |||
| dest = builder.CreateConstInBoundsGEP2_32(lt, strct, 0, i); | |||
| dest = builder.CreateConstInBoundsGEP2_32(LLVM37_param(lt) strct, 0, i); | |||
There was a problem hiding this comment.
this should perhaps have been mentioned in the commit message, but thanks
|
We'll never know what it was because libgit2 does not report actual error for windows connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15838