Re-DLLEXPORT jl_read_soname
#16361
Merged
Re-DLLEXPORT jl_read_soname
#16361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that's what caused that regression in using package manager providers? Good catch. Can we add a test via ccall or something to approximate the BinDeps usage? |
|
We can add a test to make sure it's exported I don't think it's easy to approximate the BinDeps usage though, since this is only necessary when new library is installed. |
This is still necessary for `BinDeps` after new packages are installed.
|
Test added... (And I realized that I forgot to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was un
DLLEXPORTed in #13485 but it is still necessary forBinDepsafter new packages are installed. This is causing travis failure for packages that use the package manager providers (e.g. GSL.jl)Also make the usage in base thread safe.
jl_lookup_sonameis still not threadsafe but could be made so if necessary (the easiest and non-breaking way would be internalizing it with a symbol, changing the API is also possible).@vtjnash