memoize more type properties #16320
Merged
memoize more type properties #16320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes. I've seen jl_has_typevar show up as a hotspot in perf regularly while doing other things. cool :) |
| @@ -110,14 +120,17 @@ static int jl_has_typevars__(jl_value_t *v, int incl_wildcard, jl_value_t **p, s | |||
| for(i=0; i < l; i++) { | |||
| jl_value_t *elt = jl_svecref(t, i); | |||
| if (elt != v) { | |||
| if (jl_has_typevars__(elt, incl_wildcard, p, np)) | |||
| if (jl_has_typevars__(elt, incl_wildcard, p, np)) { | |||
| if (expect > 0) assert(expect); | |||
There was a problem hiding this comment.
Doesn't this condition make the assert a no-op?
has-typevars is called pretty heavily during intersection and subtyping so it can be a hot-path also fix jl_new_type_constructor to stop mutating (aka corrupting) the immutable TypeVars it is given as a parameter
have lowering emit the correct TypeVar expression instead of fixing it in the TypeConstructor constructor
have lowering emit the correct TypeVar expression instead of fixing it in the DataType constructor
|
LGTM. Looks like some commits should be squashed. |
|
Fortunately, that's now easy to do in GitHub so you can actually just merge this if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type properties are accessed heavily by subtyping and intersection, so it's generally worthwhile to memoize them upon construction.
@carnaval I think you had separately observed this during profiling? Currently, I've also left in the old code paths and use it verify that the cached value is correct when using a debug build.