Fix Symbol redefinition warnings #16173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are dot operators that are more than 2 characters long that these loops may want to extend to in the future, leaving the 2:end the way it was will be less error prone
expr.jl is included in both Inference and Base, so split these methods into coreimg.jl and sysimg.jl
| Symbol(s::UTF8String) = Symbol(s.data) | ||
| Symbol(a::Array{UInt8,1}) = | ||
| ccall(:jl_symbol_n, Ref{Symbol}, (Ptr{UInt8}, Int32), a, length(a)) | ||
|
|
There was a problem hiding this comment.
I think most of the builtin type constructors are defined in boot.jl. Putting it here should be good also as long as nothing before this depends on it.
and an unnecessary identity method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix a review issue from #16154.
If there's a cleaner place to put these methods to avoid redefinition warnings, suggestions are welcome.
Symbolis a builtin type andbase/expr.jlgets included both incoreimg.jlandsysimg.jl, but looks like the varargSymbolconstructor is not needed in Inference (andstringisn't defined yet there anyway).