Improvements to sound module (N-bit samples + EXTENSIBLE) #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds support for all bit widths between 1 and 64 (inclusive). Previously, the WAVE code only supported "common" bit widths, but some concern was raised on the mailing list. This update implements logic to read and write files that use any bit width.
The extensible tag was added to the WAVE specification in order to clear up some of the unclear parts of the original. The extensible format tag is used when the WAVE file contains more than two channels, or the number of bits does not equal 8 or 16.
JeffBezanson
added a commit
that referenced
this pull request
Nov 16, 2012
Improvements to sound module (N-bit samples + EXTENSIBLE)
fredrikekre
pushed a commit
that referenced
this pull request
Dec 23, 2019
…34186) $ git log --oneline 8e236a7f993f1e732ffd0ab5c15736b2594e4109^..6c29d6c5421b4e3d872ccf42bd775b627b300069 6c29d6c provide a fallback when sandboxing projects with no project file (#1549) b9bcd6a Do not ever attempt to set owner when extracting (#1557) 50581b2 Add try/catch around call to realpath in safe_realpath (#1547) fb248f4 Remove Test which was added as a dependency by accident (#1553) 180d51e Disable needless specialization in Artifacts code (#1543) 7e42dfa telemetry: remove commit header (#1551) a9d85e7 Adjust GC delay and add `--all` flag to circumvent delay (#1540) 8e236a7 Merge pull request #1544 from JuliaLang/sk/telemetry 90b8482 telemetry: factor out telemetry file loading 228fb97 CI telemetry: send indicators for common CI env vars 246dbd0 Pkg protocol: basic anonymous opt-out telemetry
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
…34186) $ git log --oneline 8e236a7f993f1e732ffd0ab5c15736b2594e4109^..6c29d6c5421b4e3d872ccf42bd775b627b300069 6c29d6c provide a fallback when sandboxing projects with no project file (#1549) b9bcd6a Do not ever attempt to set owner when extracting (#1557) 50581b2 Add try/catch around call to realpath in safe_realpath (#1547) fb248f4 Remove Test which was added as a dependency by accident (#1553) 180d51e Disable needless specialization in Artifacts code (#1543) 7e42dfa telemetry: remove commit header (#1551) a9d85e7 Adjust GC delay and add `--all` flag to circumvent delay (#1540) 8e236a7 Merge pull request #1544 from JuliaLang/sk/telemetry 90b8482 telemetry: factor out telemetry file loading 228fb97 CI telemetry: send indicators for common CI env vars 246dbd0 Pkg protocol: basic anonymous opt-out telemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people raised concerns because the wave didn't support 64 bit samples. This pull request remedies that (and adds support for any bit width from 1 through 64). It also adds support for the "extensible" format tag.