Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15330: Replaced "factorial" with "fact" #15331

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Fixes #15330: Replaced "factorial" with "fact" #15331

merged 1 commit into from
Mar 3, 2016

Conversation

Dawny33
Copy link

@Dawny33 Dawny33 commented Mar 2, 2016

Replaced the function name in the docs from factorial to fact, for making the example copy-pasteable

Replaced the function name in the docs from `factorial` to `fact`, for making the example `copy-paste`able
@jiahao
Copy link
Member

jiahao commented Mar 2, 2016

I don't understand the purpose of this change. Isn't it already copy-pastable as is?

@mbauman
Copy link
Member

mbauman commented Mar 2, 2016

Since the current name shadows Base.factorial, the example only works if you haven't called factorial before defining it. Renaming it eliminates that potential snag.

@jiahao
Copy link
Member

jiahao commented Mar 2, 2016

Ah, got it.

hayd added a commit that referenced this pull request Mar 3, 2016
Fixes #15330: Replaced "factorial" with "fact"
@hayd hayd merged commit 064b03c into JuliaLang:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants