Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add casts to fix compile on Clang 3.7 #15034

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

ihnorton
Copy link
Member

The other call-sites have this cast. (AFAICT travis is on Clang 3.5, maybe Clang 3.7 is stricter?)
Fixes:

/Users/inorton/git/jldev/src/debuginfo.cpp:1134:3: error: no matching function for call to 'processFDEs'
  processFDEs(Addr, Size, [](const char *Entry) {
  ^~~~~~~~~~~
/Users/inorton/git/jldev/src/debuginfo.cpp:1089:13: note: candidate function [with callback = (lambda at
      /Users/inorton/git/jldev/src/debuginfo.cpp:1134:27)] not viable: no known conversion from 'uint8_t *' (aka 'unsigned char *') to 'const char *'
      for 1st argument
static void processFDEs(const char *EHFrameAddr, size_t EHFrameSize, callback f)
            ^
/Users/inorton/git/jldev/src/debuginfo.cpp:1148:4: error: no matching function for call to 'processFDEs'
   processFDEs(Addr, Size, [](const char *Entry) {
   ^~~~~~~~~~~
/Users/inorton/git/jldev/src/debuginfo.cpp:1089:13: note: candidate function [with callback = (lambda at
      /Users/inorton/git/jldev/src/debuginfo.cpp:1148:28)] not viable: no known conversion from 'uint8_t *' (aka 'unsigned char *') to 'const char *'
      for 1st argument
static void processFDEs(const char *EHFrameAddr, size_t EHFrameSize, callback f)
            ^
2 warnings and 2 errors generated.
make[1]: *** [debuginfo.o] Error 1

cc @yuyichao

@tkelman
Copy link
Contributor

tkelman commented Feb 12, 2016

SubArray failure unrelated, Travis failed to start? closing and reopening to fix the latter

@tkelman tkelman closed this Feb 12, 2016
@tkelman tkelman reopened this Feb 12, 2016
@yuyichao
Copy link
Contributor

LGTM, these are the the OSX defs so not really what I changed/tested.

ihnorton added a commit that referenced this pull request Feb 12, 2016
Add casts to fix compile on Clang 3.7
@ihnorton ihnorton merged commit ea1fbb4 into JuliaLang:master Feb 12, 2016
@ihnorton ihnorton deleted the fix_clang37_build branch February 12, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants