Make jl_current_module thread local #14728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I would remove ti_threadgroup_barrier in a separate commit since it's really not related to this. |
So that `eval`ing on a thread won't interfere with other thread. Add test for this and make sure that the current module on the thread is still the same with the one on the main thread with the work is created. Fix #14726
Since it appears to be leaky and not needed anymore.
6e3330d
to
c72c221
Compare
|
Done. |
|
Tests passes with threading enabled locally. |
|
Thanks. |
yuyichao
added a commit
that referenced
this pull request
Jan 20, 2016
Make jl_current_module thread local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that
evaling on a thread won't interfere with other threads.Add test for this and make sure that the current module on the thread is still the same with the one on the main thread with the work is created.
Also remove
ti_threadgroup_barriersince it appears to be leaky and not used anymore.Fix #14726