Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unspecialized is now index 7 rather than 6 #14710

Merged
merged 1 commit into from
Jan 18, 2016
Merged

unspecialized is now index 7 rather than 6 #14710

merged 1 commit into from
Jan 18, 2016

Conversation

Keno
Copy link
Member

@Keno Keno commented Jan 18, 2016

An extra field was added in fb8c6e9, but this number was not updated.

@JeffBezanson

An extra field was added in fb8c6e9, but this number was not updated.
@tkelman tkelman added the needs tests Unit tests are required for this change label Jan 18, 2016
@JeffBezanson
Copy link
Sponsor Member

Thanks!!

@Keno
Copy link
Member Author

Keno commented Jan 18, 2016

I'll merge this because people are starting to use Cxx again, and this breaks it. Can you think of a julia accessible test that would actually meaningfully break if this regressed again?

Keno added a commit that referenced this pull request Jan 18, 2016
`unspecialized` is now index 7 rather than 6
@Keno Keno merged commit 22851d6 into master Jan 18, 2016
@JeffBezanson
Copy link
Sponsor Member

My branch removes those lines, so I wouldn't worry about it.

@tkelman tkelman deleted the kf/lam branch January 18, 2016 23:07
@tkelman tkelman removed the needs tests Unit tests are required for this change label Jan 18, 2016
@StefanKarpinski
Copy link
Sponsor Member

This seems like a standard use-case for #define constants.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 19, 2016

or offsetof(jl_lambda_info_t, unspecialized) / sizeof(void*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants