Increase the signal stack size on AArch64 #14700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default size is too small for libunwind and causes a stack overflow. (The symptom is error/segfault on exit due to random corruption of heap memory, a lot of the time a segfault in
__cxa_finalize
).Also add a guard page to the signal stack making it easier to detect such problems in the future. (Segfault instead of weird corruption...)
P.S. The default size for linux x86_64 is also quite small (8k), I'm a little surprised that our signal handler works fine in such a shallow stack....
c.c. @vtjnash