Patch lldb-3.7.1 to build on mac #14603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should this be deletion or addition? |
367e535
to
171b4ae
Compare
|
Must have left out |
| + | ||
| ifeq ($(HOST_OS),MingW) | ||
| $(eval $(call DIR_SOURCES,windows)) | ||
| +SOURCES += posix/ConnectionFileDescriptorPosix.cpp |
There was a problem hiding this comment.
the posix here concerns me, mingw is not posix
There was a problem hiding this comment.
That is from upstream, but I think it was committed directly: https://www.mail-archive.com/[email protected]/msg03413.html
I'll take it out, although I don't have a windows build right now to test. ... I'm not sure if anyone else actually builds LLVM with MinGW and Makefiles any more.
There was a problem hiding this comment.
I've never built lldb so no idea whether the file name concern is justified.
171b4ae
to
c63fabb
Compare
ihnorton
added a commit
that referenced
this pull request
Jan 10, 2016
Patch lldb-3.7.1 to build on mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref llvm-mirror/lldb@6fc7df5c414
@Keno