Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plain rendering of markdown horizontal rule #14462

Merged
merged 1 commit into from
Dec 22, 2015

Conversation

thofma
Copy link
Contributor

@thofma thofma commented Dec 22, 2015

The "–" needs to be replaced by an ordinary dash "-" to produce properly formatted markdown.

ivarne added a commit that referenced this pull request Dec 22, 2015
Fix plain rendering of markdown horizontal rule
@ivarne ivarne merged commit e37971a into JuliaLang:master Dec 22, 2015
@ivarne
Copy link
Sponsor Member

ivarne commented Dec 22, 2015

Ooops!!

There was a test that tested the presence of the wrong character.

@ivarne
Copy link
Sponsor Member

ivarne commented Dec 22, 2015

We're definitely past the point where obvious fixes doesn't break tests.

@thofma You'll have to submit this PR again after fixing the tests. I did not want to leave master broken waiting for a fix.

@thofma thofma restored the th/markdown branch December 22, 2015 08:37
@thofma
Copy link
Contributor Author

thofma commented Dec 22, 2015

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants