Loosen signature on scale #14372
Merged
Loosen signature on scale #14372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on #13803, sort of (or rather, has a slight git conflict with the other part of these lines) |
3 tasks
|
If you'd like, I can prepare a dedicated PR against |
|
The conflict's easy enough to resolve, just not entirely decided on whether to try running #13803 through pkgeval or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial, but making it a PR rather than a push so I can apply the backport tag. (The added tests fail on 0.4.)
I also noticed that
Diagonalhas some restrictive methods (e.g., for*), but I was a bit concerned that generalizing them would cause ambiguity warnings for every package-defined AbstractMatrix type out there.