Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup lapack.jl #14309

Merged
merged 3 commits into from
Dec 14, 2015
Merged

Cleanup lapack.jl #14309

merged 3 commits into from
Dec 14, 2015

Conversation

jakebolewski
Copy link
Member

  • remove error checking macros
  • check for error's consistently
  • try to adhere to some semblance of standard formatting

@kshyatt kshyatt added the domain:linear algebra Linear algebra label Dec 7, 2015
@kshyatt
Copy link
Contributor

kshyatt commented Dec 7, 2015

💯

@tkelman
Copy link
Contributor

tkelman commented Dec 7, 2015

You're having too much fun with gesdd and gesvd. Or maybe not enough.

@jakebolewski
Copy link
Member Author

@tkelman any clues as to these ENOSPC error's?

@tkelman
Copy link
Contributor

tkelman commented Dec 9, 2015

docker quotas? ref travis-ci/travis-ci#5241, maybe try a branch build with group: edge to see if we pass there? how big are the temp files our tests create?

@jakebolewski
Copy link
Member Author

I am going to merge as the appveyor failure is unrelated.

jakebolewski added a commit that referenced this pull request Dec 14, 2015
@jakebolewski jakebolewski merged commit 0648133 into master Dec 14, 2015
@jakebolewski jakebolewski deleted the jcb/cleanuplapack branch December 14, 2015 19:01
@KristofferC
Copy link
Sponsor Member

Nice job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants