Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't promote flipsign arguments for signed integers #14302

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Don't promote flipsign arguments for signed integers #14302

merged 1 commit into from
Dec 9, 2015

Conversation

eschnett
Copy link
Contributor

@eschnett eschnett commented Dec 7, 2015

Neither flipsign nor copysign promote arguments in any other case.

@tkelman tkelman added the needs tests Unit tests are required for this change label Dec 7, 2015
@eschnett
Copy link
Contributor Author

eschnett commented Dec 7, 2015

Added tests.

@tkelman tkelman removed the needs tests Unit tests are required for this change label Dec 7, 2015
@eschnett eschnett force-pushed the eschnett/flipsign2 branch 3 times, most recently from 4a63c08 to b1f0094 Compare December 8, 2015 00:29
@eschnett
Don't promote flipsign arguments for signed integers
3181bd9 
Neither flipsign nor copysign promote arguments in any other case.
jakebolewski added a commit that referenced this pull request Dec 9, 2015
@jakebolewski
Merge pull request #14302 from eschnett/eschnett/flipsign2
e7a2986 
Don't promote flipsign arguments for signed integers
@jakebolewski jakebolewski merged commit e7a2986 into JuliaLang:master Dec 9, 2015
@eschnett eschnett deleted the eschnett/flipsign2 branch December 9, 2015 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschnett @jakebolewski @tkelman