fix bug in spawn test's usage of search #14123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searching for a substring returns a range, not a tuple, so these could never fail
| @test search(out,"world") != (0,0) | ||
| @test search(out,"hello") != (0,0) | ||
| @test search(out,"world") != 0:-1 | ||
| @test search(out,"hello") != 0:-1 |
There was a problem hiding this comment.
i often want to try to add an inverse test like @test search(out, "fail") == 0:-1 to help catch these sorts of errors. it's not often easy to write though.
tkelman
added a commit
that referenced
this pull request
Nov 28, 2015
fix bug in spawn test's usage of search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searching for a substring returns a range, not a tuple, so these could never fail