Add symbol / string versions of find_library #14044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,9 @@ end | |||
|
|
|||
| cd(dirname(@__FILE__)) do | |||
|
|
|||
| # @test !isempty(Libdl.find_library(["libccalltest"], [dirname(@__FILE__)])) | |||
| @test !isempty(Libdl.find_library(["libccalltest"], [dirname(@__FILE__)])) | |||
There was a problem hiding this comment.
this no longer builds in test/, it's under $(build_shlibdir) now
There was a problem hiding this comment.
Julia/julia-dev [jcb/findlib●] » ls -l test/* | grep ccalltest
-rwxr-xr-x 1 jacobbolewski staff 16528 Sep 13 15:25 test/libccalltest.dylib
test/libccalltest.dylib.dSYM:?
There was a problem hiding this comment.
that's stale and leftover from when it used to build there
relax find_library argument types to any iterable
jakebolewski
force-pushed
the
jcb/findlib
branch
from
2277b09
to
7e8c4a3
Compare
|
lgtm |
jakebolewski
added a commit
that referenced
this pull request
Nov 20, 2015
Add symbol / string versions of find_library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax
find_libraryargument types to any iterable