Ensure the backtrace is shown even if we can't show method candidates #13904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need the catch? |
timholy
force-pushed
the
teh/methoderrors
branch
from
b21ba8e
to
4778f17
Compare
|
I do now 😄 |
timholy
added a commit
that referenced
this pull request
Nov 8, 2015
Ensure the backtrace is shown even if we can't show method candidates
| try | ||
| show_method_candidates(io, ex) | ||
| catch | ||
| warn("Unable to show method candidates") |
There was a problem hiding this comment.
shouldn't this be warn(io, ?
There was a problem hiding this comment.
I'm not sure; wouldn't you want it to go to STDERR?
There was a problem hiding this comment.
The rest of the output is going to io, seems odd to have part of it not. What about in IJulia, does this result in the warning going to the terminal that's running the kernel instead of the output cell?
There was a problem hiding this comment.
Yeah, you're right. Especially since we're already in the middle of producing output for an error. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bandaid for #13306 until the deeper cause is discovered.