add muladd(x,y,z)=x*y+z fallback #13876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay to merge? |
|
+1. I had the exact change locally but you beat me to the PR. |
jakebolewski
added a commit
that referenced
this pull request
Nov 9, 2015
add muladd(x,y,z)=x*y+z fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #13748)
Note that I kept the
Number-specific fallbacks inpromotion.jl, in addition to the fallback, because I think it is sensible to do promotion on number types. e.g.muladd(x,y,z)should do all the operations inBigFloatprecision if any of the operands areBigFloat, at least forNumberoperands.