Fix bug when cloned package does not have HEAD ref #13804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what can cause this? test? |
|
To be honest I don't know what causes this state offhand. The original code is clearly wrong though, you could never get an empty SHA here unless the HEAD did not exist. I kept running into this error and this is the obvious fix. Cloning unregistered packages seems to trigger it but I can't reproduce with the "Example" package. |
762bb46
to
1b7c4a2
Compare
0ecf018
to
fe3e81e
Compare
jakebolewski
added a commit
that referenced
this pull request
Nov 4, 2015
Fix bug when cloned package does not have HEAD ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.