DateTime conversion issues with Int32 on 32-bit #13581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @test Dates.unix2datetime(unix) == dt | ||
| @test Dates.julia2datetime(julian) == dt | ||
| end |
There was a problem hiding this comment.
Missing new line at the end of the file?
There was a problem hiding this comment.
I also misspelled julian2datetime as julia2datetime
|
Otherwise, LGTM. |
On 32-bit systems when using unix2datetime or julian2datetime and passing a Int32 will result in a DateTime in an extremely limited range: ``` julia> Dates.unix2datetime(div(typemin(Int32), Int32(1000))) 1969-12-07T03:28:37 julia> Dates.unix2datetime(div(typemax(Int32), Int32(1000))) 1970-01-25T20:31:23 ```
omus
force-pushed
the
dates_conversion_Int32
branch
from
e034869
to
079eec8
Compare
omus
added a commit
to invenia/TimeZones.jl
that referenced
this pull request
Oct 13, 2015
|
cc: @quinnj |
quinnj
added a commit
that referenced
this pull request
Oct 30, 2015
DateTime conversion issues with Int32 on 32-bit
|
Thanks for the ping! |
|
this is also a bug on release-0.4, yeah? |
|
yes |
tkelman
pushed a commit
that referenced
this pull request
Oct 31, 2015
On 32-bit systems when using unix2datetime or julian2datetime and passing a Int32 will result in a DateTime in an extremely limited range: ``` julia> Dates.unix2datetime(div(typemin(Int32), Int32(1000))) 1969-12-07T03:28:37 julia> Dates.unix2datetime(div(typemax(Int32), Int32(1000))) 1970-01-25T20:31:23 ``` (cherry picked from commit 079eec8) ref #13581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dates functions
unix2datetimeandjulian2datetimehave issues on 32-bit systems due to the use integer literals.Here is a brief example of the issue which can be used on 64-bit systems: