Fix get-libuv target #13273
Merged
Fix get-libuv target #13273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -808,7 +814,7 @@ clean-libuv: | |||
| -$(MAKE) -C $(BUILDDIR)/$(LIBUV_SRC_DIR) clean | |||
| -rm -rf $(build_libdir)/libuv.a $(build_libdir)/libuv.la $(build_includedir)/libuv.h $(build_includedir)/libuv-private | |||
|
|
|||
| get-libuv: $(LIBUV_SRC_FILE) | |||
| get-libuv: $(SRCDIR)/srccache/libuv/.git/HEAD | |||
There was a problem hiding this comment.
this would break the NO_GIT=1 usage. i think you can add the following rule to git-externals for the NO_GIT=0 case to fix this, however:
$$($2_SRC_FILE): | $$($2_SRC_FILE)/HEAD
touch -c $$@
ihnorton
force-pushed
the
fix_get_libuv
branch
from
03de76d
to
ec8b889
Compare
|
Those work, updated (author as you). Will merge after CI. |
ihnorton
added a commit
that referenced
this pull request
Sep 23, 2015
Fix get-libuv and get-osxunwind targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vtjnash f6665b1#commitcomment-13375393
cc @staticfloat