set LLVM_VER from LLVM_CONFIG when using system LLVM #13241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -646,6 +646,10 @@ LLVM_CONFIG := $(build_bindir)/llvm-config$(EXE) | |||
| endif | |||
| endif # LLVM_CONFIG undefined | |||
|
|
|||
| ifeq ($(USE_SYSTEM_LLVM), 1) | |||
| LLVM_VER = $(shell $(LLVM_CONFIG) --version) | |||
| endif | |||
There was a problem hiding this comment.
move the JCPPFLAGS from a few lines higher up into this same block? also there's a comment a few lines lower endif # SYSTEM_LLVM that isn't accurate any more
yuyichao
force-pushed
the
yyc/sys-llvm-ver
branch
from
b0f09e8
to
57fea2a
Compare
|
Updated |
| @@ -646,6 +642,11 @@ LLVM_CONFIG := $(build_bindir)/llvm-config$(EXE) | |||
| endif | |||
| endif # LLVM_CONFIG undefined | |||
|
|
|||
| ifeq ($(USE_SYSTEM_LLVM), 1) | |||
| JCPPFLAGS+=-DSYSTEM_LLVM | |||
| LLVM_VER = $(shell $(LLVM_CONFIG) --version) | |||
yuyichao
force-pushed
the
yyc/sys-llvm-ver
branch
from
57fea2a
to
cc12b63
Compare
|
lgtm |
yuyichao
added a commit
that referenced
this pull request
Sep 21, 2015
set LLVM_VER from LLVM_CONFIG when using system LLVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed in dbe934a but lost in #12463 . The release-0.4 branch is not affected.
@tkelman @vtjnash