make Cstring more usable as a return value #12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This is for post 0.4, right? |
|
I guess so; this is a pretty small patch, but it is not technically a bugfix. |
fd1886a
to
8cc7013
Compare
jakebolewski
added a commit
that referenced
this pull request
Sep 4, 2015
make Cstring more usable as a return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #10799, it is natural for people to use
CstringandCwstringas return values inccall, not just as argument types. This makes that work a bit better by definingconvertto pointer types andfreeandpointer_to_stringonCstring, to make it work more likePtr{UInt8}.