Fix a libuv assertion after redirect_*(::IOStream) #12144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm at a loss as to why this is failing on 32bit travis. |
|
How does one go about getting ssh to one of the travis VMs? @tkelman or anybody else who has done that before. |
|
I haven't done Travis, but I suspect you send an email to their support people. AppVeyor recently added RDP functionality where you can remote into a node if needed, that's pretty well-documented too if anyone ever needs to do that. |
|
yep [email protected], they are on Germany tz |
When passing an IOStream to redirect_*, there was still a reference to the libuv side stream, which would be used to print errors, etc. However, since the julia side is now unreferenced, it would be gc'ed and its finalizer would take the libuv side with it, leaving the C side pointer pointing to free'd memory. Fix this by recording the IOStream as the new JL_STD* stream on the C side as well.
…ne. Might fix windows
Keno
added a commit
that referenced
this pull request
Jul 16, 2015
Fix a libuv assertion after redirect_*(::IOStream)
|
There's a warning printed for the |
This was referenced Jul 19, 2015
Merged
Merged
Merged
vtjnash
added a commit
that referenced
this pull request
Jul 20, 2015
also call the julia close cleanup handler on the file pseudo-objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing an IOStream to redirect_, there was still a reference
to the libuv side stream, which would be used to print errors, etc. However,
since the julia side is now unreferenced, it would be gc'ed and its finalizer
would take the libuv side with it, leaving the C side pointer pointing to free'd
memory. Fix this by recording the IOStream as the new JL_STD stream on the C
side as well.
This is the 0.4 version of #12143.