Fix a hang in type inference after workspace() #11948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case to reproduce is:
The problem is that
LastMain
is its own parent, but it isn'tjl_main_module
, andistopmod
is apparently false, so this was evidently an infinite loop. I'm not sure if this is the right fix, but I can build Julia with it aftermake clean
, and the code above no longer hangs. Ref #11274, cc @vtjnashI will also try to add a test for this.