Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a hang in type inference after workspace() #11948

Merged
merged 1 commit into from
Jun 30, 2015
Merged

Conversation

simonster
Copy link
Member

The test case to reproduce is:

julia> f(x) = x+1;

julia> workspace()

julia> LastMain.f(2)

The problem is that LastMain is its own parent, but it isn't jl_main_module, and istopmod is apparently false, so this was evidently an infinite loop. I'm not sure if this is the right fix, but I can build Julia with it after make clean, and the code above no longer hangs. Ref #11274, cc @vtjnash

I will also try to add a test for this.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 30, 2015

lgtm

JeffBezanson added a commit that referenced this pull request Jun 30, 2015
Fix a hang in type inference after workspace()
@JeffBezanson JeffBezanson merged commit d092dd0 into master Jun 30, 2015
@simonster simonster deleted the sjk/workspace-hang branch June 30, 2015 18:30
simonster added a commit that referenced this pull request Jun 30, 2015
Runs in a separate process, because running workspace() in the middle
of the tests seemed like a recipe for non-deterministic bugs
simonster added a commit that referenced this pull request Jun 30, 2015
Runs in a separate process, because running workspace() in the middle
of the tests seemed like a recipe for non-deterministic bugs
tkelman added a commit that referenced this pull request Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants