Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JL_GC_MARKSWEEP option #11811

Merged
merged 1 commit into from
Jun 23, 2015
Merged

Conversation

yuyichao
Copy link
Contributor

  1. We don't really need it
  2. It doesn't compile anymore and I don't think we should try to keep it

@vtjnash @carnaval

@StefanKarpinski
Copy link
Sponsor Member

+1

@JeffBezanson
Copy link
Sponsor Member

Yeah +1

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 22, 2015

We don't really need it

it helped me with porting julia to ppc, until I could figure out why the gc was corrupting memory on that platform

It doesn't compile anymore and I don't think we should try to keep it

but on the other hand, its generally not much work to patch back it back into a working state

@JeffBezanson
Copy link
Sponsor Member

until I could figure out why the gc was corrupting memory on that platform

What was needed for that, exactly? Would it have been enough just to disable collection?

@StefanKarpinski
Copy link
Sponsor Member

Can't you just turn off the GC with gc_enable(false) and achieve the same effect?

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 22, 2015

i think it may have been enough just turning on MEMDEBUG, but hindsight is 20/40 (since I don't actually remember all the specifics)

@StefanKarpinski
Copy link
Sponsor Member

So the question is whether there's anything this remains useful for that we don't have a better approach to, like turning off GC via gc_enable(false) or turning on MEMDEBUG.

@tkelman
Copy link
Contributor

tkelman commented Jun 22, 2015

hindsight is 20/40 (since I don't actually remember all the specifics)

keep notes, man

JeffBezanson added a commit that referenced this pull request Jun 23, 2015
@JeffBezanson JeffBezanson merged commit a1378b4 into master Jun 23, 2015
@vtjnash vtjnash deleted the yyc/remove-jl_gc_marksweep branch June 23, 2015 04:55
yuyichao added a commit to yuyichao/julia that referenced this pull request Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants