fix #11726: updates for llvm-svn api changes #11743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # ifdef LLVM37 | ||
| Value *addr = builder.CreateConstInBoundsGEP2_32( | ||
| cast<PointerType>(strct->getType()->getScalarType())->getElementType(), | ||
| strct, 0, idx); |
There was a problem hiding this comment.
not sure if this is correct. I thought that it would just be elty here, but that causes LLVM to assert out, so I used the type that is checked in the failing assertion... seems to work, but unsightly.
There was a problem hiding this comment.
i think you can write the same a bit more concisely as strct->getContainedType(0). i'm surprised as well that it's not the same as elty in some or all cases though.
There was a problem hiding this comment.
I'll check and change later. the failing case was GenSym in inference, FWIW.
vtjnash
added a commit
that referenced
this pull request
Jun 18, 2015
fix #11726: updates for llvm-svn api changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.