Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #11737

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Fix compiler warnings #11737

merged 1 commit into from
Jun 17, 2015

Conversation

yuyichao
Copy link
Contributor

Fix two compiler warnings.

  1. In ccalltest, the volatile variable pointing to a function that returns integer is incorrectly declare as a variable pointing to a function that returns volatile integer.
    The compiler gives a warning and I'm 90% sure I've got it right but I'm not a expert on these const/volatile modifiers and please tell me if I got it wrong.
  2. A underflow check in flisp is no-op. It can probably be removed since the second check should cover it but it's probably better to make it explicit in the source code.

@JeffBezanson maybe the second one should be cherry-picked back to femtolisp if it wasn't fixed there already?

JeffBezanson added a commit that referenced this pull request Jun 17, 2015
@JeffBezanson JeffBezanson merged commit 2b695ae into master Jun 17, 2015
@yuyichao yuyichao deleted the yyc/compile-warning branch June 17, 2015 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants