Control worker startup timeout via an env variable #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bikeshed: |
|
+1 for |
|
Yes, Julia environment variables should all start with |
2e876c0
to
2f599d9
Compare
|
Changed to |
|
👍 This will be very useful on clusters. |
|
Merging. Travis errors are due to the OOM killer. |
amitmurthy
added a commit
that referenced
this pull request
Jun 4, 2015
Control worker startup timeout via an env variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, worker processes wait upto 60.0 seconds for the master process to connect upon launch, and terminate if the master fails to do so. It has been noticed that this is not sufficient in certain cases.
This PR makes this timeout configurable via env variable
JWORKER_TIMEOUT. Default value continue to be 60.0 seconds. Custom cluster managers can specify this in the worker's env while launching a worker. For SSHManager,JWORKER_TIMEOUTis picked up from master process's env, if defined.The alternative to using an env variable was to have it specified as a julia exe option, which I wanted to avoid.
cc @andreasnoack