Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTuples made me sad (so I nixed them) #11242

Merged
merged 16 commits into from
May 5, 2016
Merged

NTuples made me sad (so I nixed them) #11242

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c4f54d1
Add a length parameter N to Vararg, Vararg{T,N}
timholy May 3, 2015
add7a23
implement Vararg{T,N} type rules
timholy May 3, 2015
59ed8a2
Add docs and NEWS on Vararg{T,N}
timholy May 18, 2015
2d43a66
Don't assume a limited set of types for N in Vararg{T,N}
timholy May 18, 2015
bc3ed5d
Add more Vararg{T,N} tests
timholy May 18, 2015
f57b858
Incorporate type_match_invariance_mask in tuple_match
timholy Jan 3, 2016
df69bfd
Add space in Vararg test expectation
timholy Jan 3, 2016
7694e3b
Provide more useful debugging info from testintersect
timholy Jun 4, 2015
d0bf8f8
Fix segfault with invoke
timholy Jun 4, 2015
f75e9d3
Fix Type{Tuple{}} <: Type{NTuple{TypeVar(:N,true)}}
timholy Jun 4, 2015
59160f2
Validate Vararg parameters
timholy Jan 3, 2016
7ee35b0
Re-fix #12092
timholy Jan 3, 2016
82ef48c
Rename enum types
timholy Jan 10, 2016
1f4ae21
Delete unused inst_tupletype_unchecked_uncached
timholy Jan 10, 2016
c66aeb3
Fix Vararg method printing
timholy Apr 10, 2016
92ac59a
normalize more Tuple{Vararg{T,N}} to Tuple{T,...}
vtjnash Apr 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-fix #12092
  • Loading branch information
@timholy
timholy committed May 5, 2016
commit 7ee35b0c883aab3c5937e6d4e8ef89edcf6bc27a
2 changes: 1 addition & 1 deletion src/jltypes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,7 +2655,7 @@ static int jl_tuple_morespecific(jl_datatype_t *cdt, jl_datatype_t *pdt, int inv
if (!pseq)
pseq = (pi<plenr) && plenkind != JL_TUPLE_FIXED && jl_is_vararg_type(parent[pi]);
if (ci >= clenf && !cseq)
return some_morespecific || pi>=plenf || (pseq && !invariant);
return 1;
if (pi >= plenf && !pseq)
return some_morespecific;
if (ci < clenr) {
Expand Down